search

thibautjombart / adegenet

adegenet: a R package for the multivariate analysis of genetic markers
165 stars 64 forks source link

add sanity check to n.pca.max to default to max value if vector #323

Closed pdimens closed 2 years ago

pdimens commented 2 years ago

This is an extra sanity check to make sure https://github.com/thibautjombart/adegenet/issues/322 cannot happen

zkamvar commented 2 years ago

Thank you for the contribution! I will need to add a test in https://github.com/thibautjombart/adegenet/blob/master/tests/testthat/test_xval.R to make sure it does not regress.

Could you add your name to the DESCRIPTION file with a "ctb" role?

pdimens commented 2 years ago

Added