Review code of functions implementing the model

thibautjombart / covid19_bed_occupancy

Shiny app providing estimates of future bed occupancy given recent admissions

https://cmmid-lshtm.shinyapps.io/hospital_bed_occupancy_projections/

Other

12 stars 5 forks source link

Review code of functions implementing the model #17

Closed thibautjombart closed 4 years ago

thibautjombart commented 4 years ago

The following 3 files in app/R/ implement the model (the rest is merely auxiliary functions):

[x] predict_admissions.R: predict daily incidence of admissions
[x] predict_beds.R : uses the input of the above and info on duration of hospitalisation to predict bed requirements
[x] run_model.R: wraps around the first 2

thibautjombart commented 4 years ago

@noamross if you wanted to get an idea of how the model works you could have a look at these files, these are the main functions implementing bed predictions. Should be good to go once this PR is through (within minutes).

esnightingale commented 4 years ago

Have looked through and don't have anything to add.

thibautjombart commented 4 years ago

@esnightingale Great thanks.

esnightingale commented 4 years ago

The amendment for % doubling error isn't quite right - since you're dividing by 1+/-error the low and high come out the wrong way around. Just need to swap the +/- I think?

thibautjombart commented 4 years ago

Sorry there's been lots of changes over the last hours. Current release candidate is now on master

samclifford commented 4 years ago

Can this be closed now?