search

thibautjombart / covid19_bed_occupancy

Shiny app providing estimates of future bed occupancy given recent admissions
https://cmmid-lshtm.shinyapps.io/hospital_bed_occupancy_projections/
Other
12 stars 5 forks source link

Welcome text partially under menu bar #58

Open samclifford opened 4 years ago

samclifford commented 4 years ago

When launched on my Mac, the text box is obscured by the menu bar because the menu bar doesn't have enough horizontal space and so ends up on two lines. It's the weird position being too narrow for one line but too wide for mobile layout.

thibautjombart commented 4 years ago

Thanks for checking. Could you share a screenshot to get a better idea of the issue?

samclifford commented 4 years ago
Screen Shot 2020-04-08 at 11 58 18 am Screen Shot 2020-04-08 at 11 58 26 am Screen Shot 2020-04-08 at 11 58 31 am

This might be solveable by moving the title of the app to be outside the menu bar and removing the CMMID logo (other apps are made available via the cmmid.github.io page and are wrapped inside that site's layout style).

thibautjombart commented 4 years ago

Just to check: can you try seeing this on firefox or chrome? The native browser in RStudio is terrible, it might just work on chrome?

thibautjombart commented 4 years ago

On a separate point: indeed the logo may not be that useful. It looks good when the app is run on its own, but not on the CMMID website (shot of the old version): image

samclifford commented 4 years ago

I get the same behaviour on Chrome and Safari.

samclifford commented 4 years ago

To be clear, this is resolved by resizing the window.

thibautjombart commented 4 years ago

Okay I can reproduce the issue. It seems it might be a css issue? It was also present in the previous version: image

samclifford commented 4 years ago

Stripping out the CMMID logo would solve this. In any case, it's redundant when displayed in the CMMID.github.io page.

thibautjombart commented 4 years ago

Let's strip it then?

On Mon, 27 Apr 2020 at 15:26, Sam Clifford notifications@github.com wrote:

Stripping out the CMMID logo would solve this. In any case, it's redundant when displayed in the CMMID.github.io page.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/thibautjombart/covid19_bed_occupancy/issues/58#issuecomment-620021623, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACSCIIUSQNQ7GGLOVWMA3P3ROWI2HANCNFSM4MDYGBIQ .

samclifford commented 4 years ago

This is fixed... somewhere. At least before b0e2b1bb3193493ca0ad1600266c21439bfabd5b