Closed angelnu closed 7 years ago
This is awesome ! The code looks sensible and clean to me, the style is consistent, what could one ask for ? :)
Oh yeah, you could reindent a few data structures as commented in the commit, and add your name to contributors in the README ;)
I am glad that you take my contribution :-)
I did not see any comments in the commit but I think I fixed all the inconsistent aliments.
If you could please publish a new version to npm I would appreciate - this way I can release an update to my exploiter package to make use of the official version. Thanks.
I could rework the example code I used to test and make it work as generic testcase using example mp3 hosted by google. I would then open a different issue for it.
Could be useful as a wiki linked from the readme. I'll publish asap
I added the example as testcase: it can either be executed directly with npm examples/queue.js
or with npm test
I will do an extra pull request for it so that it can be reviewed separately from the main code in this request. Being the first testcase I write in javascript it might require changes.
Merged and published as 1.2.0 (minor upped)
Hi,
Based on #38 I added support for queues to the default media player. I tested it with audio files and it works fine (see example exploiter bellow).
I noticed a positive side effect even for single URLs: it is possible to update the metadata in the middle of the play without having to reload (=interrupt) it.
I found additional parameters for the messages by looking at the receiver event data which is documented here: https://developers.google.com/cast/docs/reference/receiver/cast.receiver.MediaManager.QueueUpdateRequestData
Thanks to @jeffdagala and @thibauts !