search

thibauts / node-castv2-client

A Chromecast client based on the new (CASTV2) protocol
MIT License
645 stars 92 forks source link

Passing Original INPUT ID through node #94

Open pvklink opened 4 years ago

pvklink commented 4 years ago

Hi, i use your node for streaming webcams and it works great. Thank you for that!

I only had one issue. The original msg ID (_msgid) is not passed through. So i cant merge this node output with other splitted messages . When a node dont passes al previous info and dont pass the original ID it is hard to keep parts of flows together and keep flow information complete

See: https://nodered.org/docs/creating-nodes/ Nodes should document what properties they ADD to messages, and they should be consistent and predictable in their behaviour.

i8beef commented 3 years ago

You're in the wrong repo. You wanted https://github.com/i8beef/node-red-contrib-castv2...

But just FYI with 3.x of that node, released this week, the functionality has completely changed, and there is no expectation of msg continuity on the output anymore. It is a purely asynchronous flow now, so you probably need to rethink how you are using it. Feel free to open a ticket there for more help when you upgrade.