search

thielepaul / photoprism-mobile

Flutter App for PhotoPrism
GNU General Public License v3.0
893 stars 72 forks source link

App only showing original JPEG files, RAW missing? #136

Open Rolf-Smit opened 2 years ago

Rolf-Smit commented 2 years ago

Is it correct that this app is only capable of showing photos for which the original file is a JPEG file?

I have about 36.000 photos, and am currently only able to see the ones for which I have a original JPEG copy. The photos that I only have a RAW copy from, but for which PhotoPrism created a JPEG Sidecar clone, are not displayed.

Is this a feature or bug? I would love to be able to see all my photos including those that are RAW photos and I only have a Sidecar clone for.

Rolf-Smit commented 2 years ago

@thielepaul have you seen this?

thielepaul commented 2 years ago

I'd say it's a bug. I haven't tested raw files at all. This project currently has not a very high priority for me, so I don't when I would address this. Contributions are always welcome and I should always find some time to review a PR.

thielepaul commented 2 years ago

seems like this was an easy fix: https://github.com/thielepaul/photoprism-mobile/commit/ed463ea7b6a397816a487411142536e86d9c7cd5

Rolf-Smit commented 2 years ago

@thielepaul I've tested it and it works as expected now, thanks! I do wonder if it also makes sense to change the download option to give users control over whether to download the original RAW image file or just the "Sidecar" JPEG.

Anyhow I don't mind spending some time on this myself.

thielepaul commented 2 years ago

please feel free to open a PR for any feature you would like to add. I am only working on this project on an irregular basis and mostly on the features/bugs that have the highest priority for me personally