search

thielepaul / photoprism-mobile

Flutter App for PhotoPrism
GNU General Public License v3.0
896 stars 70 forks source link

Fix #26. #27

Closed muety closed 4 years ago

thielepaul commented 4 years ago

@n1try Thank you for the pull request! I was just wondering which code formatter are you using? If I run flutter format lib/main.dart, a lot of lines are changed, which is suboptimal as it gets harder to track changes and unnecessary merge conflicts might occur.

muety commented 4 years ago

I was just wondering which code formatter are you using?

I tried using Android Studio's default formatting, but that changed everything entirely. Instead I manually changed some indentations that I found overly ugly (e.g. here), but I agree that merging gets harder by doing so. Feel free to revert my formatting changes or maybe even add some kind of formatting specification (like editorconfig or so?) to have consistency while avoiding ugly indentations.

thielepaul commented 4 years ago

For the start, let's just do what the Flutter framework suggests: https://flutter.dev/docs/development/tools/formatting To enforce the formatting, I also added an check to the pipeline/Github actions (#28). Anyway, I am open for other suggestions regarding the formatting :)