thielepaul commented 3 years ago

If you want to test this branch of the App you can use the following docker image: thielepaul/photoprism:db-api

new features in this branch:

photo metadata is stored as sqlite instead of json
metadata cache is updated incrementally (before metadata cache was deleted on refresh)
filter and sort photos
tests run against the demo docker image so CI can tell when API breaks
photo upload checks if photo was uploaded against local metadata cache

TODO:

[ ] get backend changes merged: photoprism/photoprism#995
[x] tell users what is going on on initial load from backend (might take some time if its a lot of photos)
[x] fix app start when phone has no internet connection (should still start app)
[x] if all fields in the photos and files tables are used, I sometimes get sql ioerrors => investigate
[x] make photo filter/sort persistent over app restarts
[x] check if backend is reachable/needs auth/supports api

codecov-io commented 3 years ago

Codecov Report

Merging #96 (35b8498) into master (41108a7) will increase coverage by 2.52%. The diff coverage is 30.05%.

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   26.22%   28.74%   +2.52%     
==========================================
  Files          29       36       +7     
  Lines        1926     2477     +551     
==========================================
+ Hits          505      712     +207     
- Misses       1421     1765     +344

Impacted Files	Coverage Δ
lib/api/api.dart	`7.14% <0.00%> (-10.81%)`	:arrow_down:
lib/common/album_manager.dart	`0.00% <0.00%> (-44.12%)`	:arrow_down:
lib/common/db_init.dart	`0.00% <0.00%> (ø)`
lib/model/albums.dart	`0.00% <0.00%> (ø)`
lib/model/files.dart	`0.00% <0.00%> (ø)`
lib/model/photos.dart	`0.00% <0.00%> (ø)`
lib/model/photos_albums.dart	`0.00% <0.00%> (ø)`
lib/pages/photoview.dart	`0.00% <0.00%> (ø)`
lib/widgets/auth_dialog.dart	`0.00% <0.00%> (ø)`
lib/widgets/filter_photos_dialog.dart	`0.00% <0.00%> (ø)`
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 41108a7...35b8498. Read the comment docs.

Mortein commented 3 years ago

I've been unable to build in the devcontainer since this was merged, including after #110. I've rebuilt the container, but there are just a whole bunch of errors.

Were there any dependencies/changes you might've added locally? Or steps that need to be added to CONTRIBUTING.md?

thielepaul commented 3 years ago

I've been unable to build in the devcontainer since this was merged, including after #110. I've rebuilt the container, but there are just a whole bunch of errors.

Were there any dependencies/changes you might've added locally? Or steps that need to be added to CONTRIBUTING.md?

Yes, there is an additional step: flutter packages pub run build_runner build

gomme600 commented 3 years ago

Hi @thielepaul , have you seen the latest comment on the pull request for this issue ? https://github.com/photoprism/photoprism/pull/995#issuecomment-817254138

thielepaul / photoprism-mobile

Implement new db based api #96

Codecov Report