search

thielepaul / photoprism-mobile

Flutter App for PhotoPrism
GNU General Public License v3.0
892 stars 72 forks source link

Don't show images/videos marked private by default #98

Closed mrrsm closed 2 years ago

mrrsm commented 3 years ago

I'd like to see an option on the photos/videos pages to toggle showing private images inline with the items already marked as public.

thielepaul commented 3 years ago

would you prefer if the filter is persistent over app restarts or should it reset? Or should there both be a non-persistent filter on the photos-page and a persistent filter (which can be configured in the settings page)?

mrrsm commented 3 years ago

I personally would like it as a persistent setting. In my PR I had it as an option in the drop down on the photos/videos/etc pages where the upload button was. My thinking on that is that would become the place where all of the filter options could be set in the future and in theory could be separated for all of the main categories (photos, video, albums).

These thoughts are a bit out of scope but how I could see it working based on the current design: The current mobile design boils it down into only a few main categories so in general I would think that having persistent filters or even quick filter options to get to other views which are present in the web would be nice.

thielepaul commented 3 years ago

This is how it currently looks, I think I will add a "set as default" button next to the apply button.

Screenshot_20210211-201943

mrrsm commented 3 years ago

That looks great!

If that is something in the main app settings wouldn't the expected use case automatically be setting it as default as it is a setting?

If this is a popup filter from the photos page I can see it working exactly as you said as I always want the ability to make my temporary changes sticky.

thielepaul commented 3 years ago

yes it is a popup from the photos page