search

thieman / github-selfies

Everything is better with selfies. Yes, even pull requests. Trust me.
MIT License
1.14k stars 76 forks source link

GitHub enterprise support #10

Open ivey opened 10 years ago

ivey commented 10 years ago

It would be great if I could add my GH:E URL to the matches. I don't know anything about Chrome Extensions, but I'm going to dig in and see if I can figure it out.

stephenmathieson commented 10 years ago

you probably just need to edit these, but i don't know anything about github enterprise

ivey commented 10 years ago

So, I can add an options page, but it won't be able to change the manifest, and will require using programmatic injection to selectively enable the extension at runtime on the page, and will require cross-domain permissions on every site.

Probably not worth it. I will keep poking though, and maybe I will find something.

jphastings commented 10 years ago

If you're able to add permissions to a site based on tags on the page both GH:E and standard Github have this tag set in their <head>:

<meta content="GitHub" property="og:site_name">

You could give it permissions for all sites and match on *://*/*/compare/* and do a check in the code to figure out if there's a /html/head/meta[property='og:site_name'] tag, but that feels a little nasty?

gtallen1187 commented 8 years ago

Not sure if this is still being considered, but just in case, i'd like to add in a vote for GitHub enterprise support.

If it's helpful, this chrome extension seems to do a pretty decent job of supporting both github.com and enterprise options.

tal commented 7 years ago

This extension also does github + enterprise https://github.com/thecodejunkie/github.expandinizr