Should be opt-in for the camera so the camera isn't required every time I open an issue/pr

thieman / github-selfies

Everything is better with selfies. Yes, even pull requests. Trust me.

MIT License

1.14k stars 76 forks source link

Should be opt-in for the camera so the camera isn't required every time I open an issue/pr #53

Closed parkr closed 8 years ago

parkr commented 9 years ago

Every time I go to a PR or issue page, access to my camera is automatically requested which is not ideal. I'd rather see a button that says "Activate Selfies" that then fills in the UI as needed.

obfuscurity commented 9 years ago

Agreed, https://github.com/thieman/github-selfies/blob/master/chrome/selfie-base.js#L68 is pretty painful. Perhaps a dual-mode button that a) enables video and then b) click to activate the shutter? Almost like a real-life camera button that does the initial press to focus.

thieman commented 9 years ago

Just to be clear: is the hover functionality not working? The intention is that the extension shouldn't try to talk to your camera until you hover over the Selfie button. Is that broken?

Or is that working as intended and you are asking for that feature to be changed?

obfuscurity commented 9 years ago

Yes, it works on hover. The desire is that it would require manual activation, not on hover.

ahmetb commented 9 years ago