thieman / github-selfies

Everything is better with selfies. Yes, even pull requests. Trust me.
MIT License
1.14k stars 76 forks source link

Fixes JavaScript error #54

Closed Scotchester closed 9 years ago

Scotchester commented 9 years ago

I was getting this error in later versions of Chrome:

Uncaught TypeError: Failed to execute 'insertBefore' on 'Node': 2 arguments required, but only 1 present.

So I just did a quick fix by changing to the appendChild function.

Thanks for the great extension!

Scotchester commented 9 years ago

selfie-4

thieman commented 9 years ago

Probably some more info here: https://code.google.com/p/chromium/issues/detail?id=419780

thieman commented 9 years ago

Thanks! Gonna merge and then push out a new version.

Scotchester commented 9 years ago

Nice find! Interesting thread. Looks like they made the right decision in the end.