search

thieman / github-selfies

Everything is better with selfies. Yes, even pull requests. Trust me.
MIT License
1.14k stars 76 forks source link

Firefox extension is broken/abandoned #66

Closed LucasMetal closed 8 years ago

LucasMetal commented 8 years ago

Hi!

Very fun idea!

Unluckily it doesn't seem to be working anymore right now in GitHub for my version of Firefox (I'm on the beta channel). Am I the only one?

Thanks!

bhollis commented 8 years ago

Might need the same fixes as I've made for #68. I'll take a look at that if my PR gets merged.

thieman commented 8 years ago

The Firefox version is unfortunately abandoned following a lack of interest. I don't actively maintain the project any more, but there are enough Chrome users (like Ben here) using it and contributing fixes that the project's still alive. I think the Firefox version peaked at about 100 downloads so it just hasn't had the same support.

I've changed the Readme to reflect this, sorry for the confusion. If you or anybody else wants to port the current version of the Chrome extension into the Firefox part of the repo, I'd gladly merge it and reupload. Until then, we can keep this issue open to track Firefox support.

bhollis commented 8 years ago

Travis,

I'll see if I can't revive the FF plugin today. :-)

-Ben

Sent from my phone

On Dec 13, 2015, at 5:32 AM, Travis Thieman notifications@github.com wrote:

The Firefox version is unfortunately abandoned following a lack of interest. I don't actively maintain the project any more, but there are enough Chrome users (like Ben here) using it and contributing fixes that the project's still alive. I think the Firefox version peaked at about 100 downloads so it just hasn't had the same support.

I've changed the Readme to reflect this, sorry for the confusion. If you or anybody else wants to port the current version of the Chrome extension into the Firefox part of the repo, I'd gladly merge it and reupload. Until then, we can keep this issue open to track Firefox support.

― Reply to this email directly or view it on GitHub.

bhollis commented 8 years ago

@thieman, quick question - were you using cfx or jpm to package the FF extension?

thieman commented 8 years ago

I see a jetpack tag on the project in the developer hub, which makes me think I probably used jpm.

bhollis commented 8 years ago

selfie-0

This is the face I make when I have to deal with the Firefox Addon SDK (posted from Firefox, obviously :wink:)

bhollis commented 8 years ago

selfie-0 This is how I feel after another hour of wrestling with nsIHttpChannel. (Also posted from Firefox)

bhollis commented 8 years ago

Testing...

bhollis commented 8 years ago

More testing...

LucasMetal commented 8 years ago

haha cool!! Thanks for the effort guys!! :)

bhollis commented 8 years ago

selfie-0

thieman commented 8 years ago

bhollis commented 8 years ago

This should be resolved by #69 now.