search

thieman / github-selfies

Everything is better with selfies. Yes, even pull requests. Trust me.
MIT License
1.14k stars 76 forks source link

Use github's image storage? #67

Closed benjaminhollissc closed 8 years ago

benjaminhollissc commented 8 years ago

Now that GitHub allows attaching files to issues directly (githubusercontent.com), it'd be cool if this extension could optionally use that instead of imgur. Thanks!

thieman commented 8 years ago

How exactly do you use that API? I was searching around and couldn't find anything on it.

bhollis commented 8 years ago

I reverse-engineered it, and it's pretty straightforward - you POST to a GitHub API that gives you some S3 credentials, then use that to store the file, then ping them again to report success.

Unfortunately, it looks like the policy they use leaves the content publicly readable (but with a hard-to-guess URL) which is not really any better than Imgur. So my original reason for wanting this (privacy) doesn't matter.

bhollis commented 8 years ago

You can close this.

thieman commented 8 years ago

:bear:

corneadoug commented 8 years ago

I think that base64 images could be an option if this PR is merged: https://github.com/jch/html-pipeline/pull/227