Closed bhollis closed 8 years ago
OK, here's the rest of the changes:
requestAnimationFrame
for video sync, and splitting work up into a Promise
chain so the UI doesn't freeze as much while encoding the GIF.[[selfie-0 uploading...]]
so it's more like a progress indicator.Rather presumptuously, I bumped the version to 2.0.0 and added myself to the "Awesome People" table in the README.
PRs like this are exactly why we have that table. :smile:
This should fix most of the open issues in this repo.
Literally laughed out loud at this, this is amazing.
I'm doing the whole Christmas vacation thing so I might not be able to review this immediately. I'll probably just do a usability review since your JS abilities seem to be pretty head and shoulders above mine. Will get this out by the new year for sure.
Thanks! :blush:
No hurry merging this - I'm excited to get my co-workers using it in the new year, though!
If I go to the "Files Changed" sub-tab in the PR view and come back, the Selfie button is gone. However, if I go to "Commits" and come back, it's still here. That's odd.
Looks good other than those two things :+1:
I'll fix it!! š¤
I'll QA it!
oh man this new build script is so luxurious
Chrome version should be live within 60 minutes, Firefox version is apparently in some sort of review queue
Awesome, thank you for your help!
I got super carried away with working on the extension, and this is the result.
First, I want to apologize - as part of messing around with everything, I rewrote a lot of the UI code to build objects to handle the state - as a result, the code is full of
this
junk. Sorry :crying_cat_face:. I tried to reduce the impact by switching to arrow functions where possible.On to the good stuff. First, a demo: http://imgur.com/RBB6ZcZ
There are a bunch of things going on in these changes:
build.sh
that'll build both the Chrome and Firefox extension.pushState
based navigation is properly observed, and the extension correctly attaches the selfie button as you navigate around. No more having to refresh the page. I also prevent the extension from accidentally multiplying by making sure there's only ever one selfie button on the page.If you like this and decide to merge it, please don't ship the extension - I have more changes coming, but I figured I'd get this out there first.
This should fix most of the open issues in this repo.