search

thieman / github-selfies

Everything is better with selfies. Yes, even pull requests. Trust me.
MIT License
1.14k stars 76 forks source link

Slack doesn't show selfies in previews because it's a link #75

Closed thieman closed 8 years ago

thieman commented 8 years ago

From a reviewer in the Chrome store: "Good extension but it needs to just put a plain image and not make the image a link. The link causes the image not to show up in slack and that's just unacceptable :D. Maybe just append a link to the extension after the image?"

Wondering if there's some metadata we can throw somewhere to make Slack happy again.

itsrainy commented 8 years ago

I think that was my feedback. Here's what it looks like in Slack: image

I always just manually edit the markdown to exclude the link portion, which works fine. Maybe there's a different way to accomplish a link back to your repo?

itsrainy commented 8 years ago

Submitted a PR for a possible alternative: https://github.com/thieman/github-selfies/pull/77

thieman commented 8 years ago

Merged #77.