search

thieman / github-selfies

Everything is better with selfies. Yes, even pull requests. Trust me.
MIT License
1.14k stars 76 forks source link

Issue uploading selfie #87

Closed kieut closed 6 years ago

kieut commented 7 years ago

I haven't been able to pollute my PRs with github selfies ☹️ . This is similar to: https://github.com/thieman/github-selfies/issues/81

Browser: Google Chrome: Version 58.0.3029.110 (Official Build) (64-bit) Version: GitHub Selfies 2.0.3 (downloaded from Chrome Store)

This is the error that appears in the Chrome Console window when I try to take a photo selfie.

Refused to connect to 'https://api.imgur.com/3/upload' because it violates the following Content Security Policy directive: "connect-src 'self' uploads.github.com status.github.com collector.githubapp.com api.github.com www.google-analytics.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-user-asset-79cafe.s3.amazonaws.com wss://live.github.com".

jessmartin commented 7 years ago

SIMILAR! DO WANT POLLUTION! 💩

xeviknal commented 6 years ago

Bad news, github blocks all ajax request outside their services/providers: https://github.com/blog/1477-content-security-policy

Which would be the approaches to fix this? Who is up for telling github to add imgur to connect-src in CSP? :+1: or :-1:

thieman commented 6 years ago

Fixed by #91.