search

thieman / github-selfies

Everything is better with selfies. Yes, even pull requests. Trust me.
MIT License
1.14k stars 76 forks source link

Add permission for imgur #91

Closed inabajunmr closed 6 years ago

inabajunmr commented 6 years ago

I get this problem(https://github.com/thieman/github-selfies/issues/87).

I don't know deep knowledge of chrome extension. But I think when extension access outer resource, need to add permission for specific url on manifest.

I add permission for https://api.imgur.com/3/upload in this PR and it worked for my local test.

I test follow environment.

inabajunmr commented 6 years ago

Hi @thieman .

I like this tool. It's so emotional. But I can not use it and introduce to other people for problem #87.

If you ok, please merge this pr and release...

Follow's image is results of test.

Before fix

test1

After fix

test2

thieman commented 6 years ago

This definitely seems to fix some things, thanks! Pushing a new release now.

kieut commented 6 years ago

YASS!!!

thieman commented 6 years ago

@kieut I'm sorry this comment didn't include a selfie so I'm not sure I understand???

thieman commented 6 years ago

Haha hey @inabajunmr I also just realized from reading that console warning in your GIF that the extension's about to break again in a month (goddammit...). Want to take a proactive stab at that to preserve your work?

inabajunmr commented 6 years ago

@thieman Thank you merge it and release new version :octocat:

I realized this alert now... I fixed it on https://github.com/thieman/github-selfies/pull/92.