search

thieman / github-selfies

Everything is better with selfies. Yes, even pull requests. Trust me.
MIT License
1.14k stars 76 forks source link

Update imgur upload route #98

Closed cbayles closed 4 years ago

cbayles commented 5 years ago

imgur lists /upload as an alternative route for POST, but /image as the main one. I was getting the CORB error before, but this fixed it for me.

rodrimaia commented 5 years ago

Thank you! Definitely fixed it for me :)

:+1:

ricardovsilva commented 4 years ago

This fixed for me also! This PR already have 8 months, is not going to be merged?

ricardovsilva commented 4 years ago

@thieman , plz merge this one!!

selfie-1 GitHub Selfies

thieman commented 4 years ago

Wow @ricardovsilva you know exactly how to get my attention.

I'll take a look this weekend and see if this patch works, thanks @cbayles also for providing it

thieman commented 4 years ago

@ricardovsilva hey I'm definitely going to get to this still but I just realized if you put some pictures of your dogs in this thread it might be faster?

ricardovsilva commented 4 years ago

Charlinho

Lara

Charlinho and Lara

Dogos helping improve open source

cbayles commented 4 years ago

I'll get in on that! 😄 selfie-1

GitHub Selfies

thieman commented 4 years ago

This has made me realize I should add an incredibly important thread for postin' selfies https://github.com/thieman/github-selfies/issues/101

thieman commented 4 years ago

Looks good, lemme just run the integration tests

selfie-4 GitHub Selfies

Yup we're all good to go here

thieman commented 4 years ago

Alright, this is merged and submitted for review in the Chrome store. Apparently that process has gotten a lot more onerous since I last did this, they made me fill out a lot of supplemental information and they just told me it might take weeks to get the update published. It used to only take an hour. Walled gardens suck.

In the meantime, you can always run the extension from source by loading it as an unpacked extension.

cbayles commented 4 years ago

Fantastic, thanks for doing that.

ricardovsilva commented 4 years ago

Thx to @cbayles and @thieman for that. Specially during the pandemic it helps a lot to interact with guys from work. Ty!