thien-do / moai

A React component library, where buttons look like buttons🗿
https://moai.thien.do
127 stars 26 forks source link

Build: Use distribution in Docs #252

Closed thien-do closed 3 years ago

thien-do commented 3 years ago

Previously, the "docs" project import files from "core" and "gallery" directly (i.e. "../../../core"). This let us run only 1 process to watch for changes in all projects. However, this is quite wrong:

After this PR, to work on Moai you'd usually need 2 terminal windows, one for the "docs" and one for the "core". We may use "npm-run-all" to combine them later. However, this is the better way.

As a side note, the "test" project already uses this approach.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/makeinvietnam/moai-docs/6CbsQSRzkapsygSE8TiS3NXCGWpi
✅ Preview: https://moai-docs-git-fork-thien-do-link-deps-makeinvietnam.vercel.app