search

thiennc1107 / search-analyzer

MIT License
0 stars 0 forks source link

Start of the code review process 👋 #1

Closed longnd closed 8 months ago

longnd commented 8 months ago

Hello Thien 👋 , Thank you for your effort on the code submission. I am Long, engineering lead at Nimble, and I am happy to be the reviewer for our code review session. First, I am sorry for the late response as I was on leave.

During the review process, I would like to know more about your decisions, and thus I will create issues where I think there could be more improvements regarding your performance here.

At the same time, please keep in mind that this is a bi-directional process, and I would love to hear back from you as well. Therefore, do not hesitate to raise your questions or share your opinions about the implementation (if any) during the process.

If we are aligned on any issue, and you would like to correct them, please address the issue using a proper git flow (creating a new branch, opening a Pull Request (PR) per issue, and merging the code when you are ready), and I will follow up on those fixes. Please note that you don't have to close any of my created issues after merging your PRs, I will help verify and close them for you once they pass. 😇

We expect the code review process to be completed within 2-3 days at most. As a result, ensure you are responsive during this process. If you need additional time, please inform us right away so that we can plan accordingly.

In the end, I really do hope that you find the process enjoyable. Good luck and happy coding. 🤘

longnd commented 8 months ago

@thiennc1107 I have completed the initial round of code reviews focusing the most critical concerns to ensure we can keep the whole process within a few days. I am looking forward to hear your feedback on the open issues.

thiennc1107 commented 8 months ago

Hi @longnd, thanks for your reviewing, I have added some comment to your issues, please help reviewing them, Once again, thanks for helping me review these issues.

longnd commented 8 months ago

@thiennc1107 Thank you for addressing the open issues. I have replied to all of them. So it is time to wrap up this stage of the code review process. Thank you for your efforts so far. Our TA team will provide feedback to you by email.

thiennc1107 commented 8 months ago

Thanks for your feedback, I'm looking forward to your side. Best regards.

Vào Th 6, 29 thg 12, 2023 vào lúc 15:54 Long Nguyen < @.***> đã viết:

@thiennc1107 https://github.com/thiennc1107 Thank you for addressing the open issues. I have replied to all of them. So it is time to wrap up this stage of the code review process. Thank you for your efforts so far. Our TA team will provide feedback to you by email.

— Reply to this email directly, view it on GitHub https://github.com/thiennc1107/search-analyzer/issues/1#issuecomment-1871850701, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSX5ODHWHORARJHPQAHPKLYL2AM3AVCNFSM6AAAAABBFU5GNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZRHA2TANZQGE . You are receiving this because you were mentioned.Message ID: @.***>