search

thiennc1107 / search-analyzer

MIT License
0 stars 0 forks source link

Lack of Git flow #3

Closed longnd closed 8 months ago

longnd commented 8 months ago

Issue

Even though you worked solo in this project, it was a clear requirement for this code challenge that:

Use Git during the development process. Push to a public repository on Github or Gitlab. Make regular commits and merge code using pull requests.

We expect the changes to be merged by using pull requests; the reason is it helps show your planning skills, i.e. how you analyze the given requirements, break it down into smaller achievable parts, and implement them in each pull request. Also, by going through the PRs, we can evaluate if you know to use Git flow efficiently (which is crucial when working in a development team)

thiennc1107 commented 8 months ago

Thanks for your suggestion, I will notice this in up-coming changes.

longnd commented 8 months ago

Since we're aligned. This issue can now be closed.