search

thierry-martinez / stdcompat

Stdcompat: compatibility module for OCaml standard library
BSD 2-Clause "Simplified" License
31 stars 13 forks source link

Update `dune` port #16

Closed Leonidas-from-XIV closed 2 years ago

Leonidas-from-XIV commented 2 years ago

I need to use the dune feature of building the code in a subfolder. So I was happy to see that the project has a dune file, but unfortunately it turns out that this dune file doesn't build the code successfully anymore due to changes in the project that haven't been reflected in the dune file.

As such I started porting and decided to upstream the relevant changes. Maybe it would be possible to adopt this as main build, that would prevent the dune files from bitrotting.

NathanReb commented 2 years ago

@thierry-martinez have you had the chance to take a look at this?

thierry-martinez commented 2 years ago

Sorry for the very long delay and thank you for updating the port! When I run this port on OCaml 4.13 with dune 3.1.1, I have errors that come from warnings that are turned into errors by default by dune. I don't seem to be able to add commits to this PR, so I will merge first and fix that afterwards. Thank you again!

Leonidas-from-XIV commented 2 years ago

That's weird, because I usually allow pushing by maintainers… must be some Github weirdness.

Anyway, glad it worked out anyway, thanks for merging! I also added some fixes in #19 that we found while using it with opam-monorepo.