search

thierryc / Sketch-Find-And-Replace

Sketch plugin to do a find and replace on text within layers
Apache License 2.0
711 stars 37 forks source link

When I run replacing text, the text in the symbol got messed up with unknown series number #79

Closed wangzhenux closed 5 years ago

wangzhenux commented 5 years ago

Steps to reproduce:

  1. open the plugin
  2. Enter the text to find and replace
  3. Expected results: only the text matched search gets replaced
  4. Actual results: symbols with text get messed up with unknown series number jan-17-2019 16-15-32
wangzhenux commented 5 years ago

It seems the problem only happens if the text style in the symbol gets swapped (the new feature in sketch 52 where you can apply different style to each element in the symbol)

thierryc commented 5 years ago

Thank you for this issue. Yes, it is. This bug is listed "Plugin hi-jacking non-matching symbol text #76" and it will be fixed in the v2. V1 is built over the CocoaScript API.

The new v2 will be built over the JS API. Follow me on twitter to be posted.

thierryc commented 5 years ago

issue #76

thierryc commented 5 years ago

image

jane00 commented 5 years ago

v2 can not start up, oops

thierryc commented 5 years ago

@jane00 do you restart sketch ? Please try the last one. https://github.com/thierryc/Sketch-Find-And-Replace/archive/2.0.2.zip

thierryc commented 5 years ago

@jane00 @wangzhen0614

https://github.com/thierryc/Sketch-Find-And-Replace/releases/tag/2.0.3

thierryc commented 5 years ago

https://github.com/thierryc/Sketch-Find-And-Replace/releases/tag/2.0.4

image
thierryc commented 5 years ago

@jane00 your version start up now ?

jane00 commented 5 years ago

Thank you for your reply. I start the dev tool and catch the erros: 图片

jane00 commented 5 years ago

@jane00 what is your sketch version ? and your OSX version ?

UI.getTheme get the dark or light mode (Mojave)...

TypeError: UI.getTheme is not a function. (In 'UI.getTheme()', 'UI.getTheme' is null)

thierryc commented 5 years ago

you can try the 2.0.7

thierryc commented 5 years ago

@jane00

Do you have test the 2.0.7 version

jane00 commented 5 years ago

Thanks. I can open the v2.0.7. But the replace for overrides does not works. Nothing was replaced.

And another suggestion is， sometimes， only find and jump location to the found item is useful. Just like the find feature of Excel/Offiece. User wants to make sure which one will be replaced.

jane00 commented 5 years ago

OSX 13.6 Sketch 52.6 thanks.

thierryc commented 5 years ago

The v2 start to work on the 53.

"And another suggestion is， sometimes， only find and jump location to the found item is useful. Just like the find feature of Excel/Offiece. User wants to make sure which one will be replaced." Yes, it is on my todo.

thierryc commented 5 years ago

@!jame00, thank you for your feedback I will try to fix it for the 52... but if you can update to the 53.2.

thierryc commented 5 years ago

done