Update react-fullpage library and documentation

thierryc / react-fullpage

Create Fullscreen Scrolling Websites

https://thierryc.github.io/react-fullpage/

MIT License

207 stars 25 forks source link

Update react-fullpage library and documentation #60

Open ThulaniMthembu opened 3 weeks ago

ThulaniMthembu commented 3 weeks ago

Enhance package.json with new metadata and dependencies
Resolve React version conflicts (support React 17 and 18)
Fix invalid hook call errors in Fullpage component
Address npm audit vulnerabilities in development dependencies
Improve TypeScript support and resolve type errors
Boost test coverage to 100% pass rate
Create README_ENHANCED.txt with detailed updates and test results
Update main README.md with links to enhanced documentation
Rename branch to avoid conflicts with original master

ThulaniMthembu commented 3 weeks ago

Hi Thierry, I've submitted a pull request with several updates and improvements to the react-fullpage library. These changes include enhanced documentation, bug fixes, and improved compatibility with React 17 and 18. I've also addressed some npm audit vulnerabilities and improved our test coverage.

The detailed changes can be found in the pull request description. I welcome any feedback or suggestions for further improvements. Thank you for considering these updates!

thierryc commented 3 weeks ago

Thank you so much for your amazing contribution! 🎉 I’ll take a glance through everything next week and will follow up with a more detailed review after that. I’ll keep you posted on how things go.

Your hard work is really appreciated 🙌

Thanks again!

thierryc commented 3 weeks ago

Hi @ThulaniMthembu,

I wanted to bring up a small but important detail regarding the package name. To avoid potential conflicts with other projects in the NPM repository, the package should be named @ap.cx/react-fullpage rather than just react-fullpage.

This namespace helps ensure that the package remains unique and avoids issues with existing packages. Could you please update the package name accordingly?

Additionally, I will need to update the demo page on the gh-pages branch before merging. Sorry for the delay, but I’ll try to get that done this week.

Could you provide a working example or a link to a demo showcasing the changes? It would help in understanding the implementation better and ensure everything works as expected in real scenarios.

Appreciate it!

Thanks again for your work!

Best, Thierry