search

thiezn / iperf3-python

Python wrapper around iperf3
https://iperf3-python.readthedocs.org/
MIT License
110 stars 51 forks source link

Add bandwidth parameter #11

Closed cvicente closed 7 years ago

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.3%) to 98.479% when pulling 2d6b109776306b1857427822289cc5f317c986fd on cvicente:add_bw_par into da8f6a2109bcb057cf7105c7d1949e5d60b85c6c on thiezn:master.

cvicente commented 7 years ago

I'm a bit confused by the coveralls failure. It points to this line: https://coveralls.io/jobs/18807786/source_files/1591162918#L101 However I do have a test covering that condition. Let me know if there's anything I can do to get this merged. Thanks.

thiezn commented 7 years ago

Hi @cvicente Thanks for your submission and your patience, it took me a long while to find time to work on the library again. I've implemented the bandwidth parameter in commit d5f597002b654723093c472ae6952c99a5158f71

I did decide not to add the M/G prefixes as you initially worked on to keep the api simple and aligned with the official iperf3 library