Closed fciaccia closed 7 years ago
Thanks @fciaccia, You are right, I was parsing the reverse field the other way around.
I'll push the change out to PyPi later today so you can pip install
Thanks I actually have implemented a couple of features more in my branch, I'll make you the pull request so you can check them before pushing to pip. thanks again!
Hi, first, thank you very much for the work you have been doing with this project, it is really useful. I was modifying the TestResult class to correctly handle the case in which the user wants to disable the json_output when I found out this: https://github.com/thiezn/iperf3-python/blob/master/iperf3/iperf3.py#L615
Here we are returning the opposite value of the reverse field respect to the JSON passed from the client. The semantic usage of the -R flag in iperf3 cli is (from man):
which means that reverse is not a relative value (i.e. it does not depends on the result being returned by the client or the server) and its default value should be False. BTW, also the test is checking for a True value when we are actually not setting the reverse flag, line: https://github.com/thiezn/iperf3-python/blob/master/tests/test_iperf3.py#L154 . Checking the response from the client actually shows:
Thanks for any feedback provided, Francesco
PS. my editor automatically removed some whitespaces, just noticed.