search

thigoap / eleventy-plugin-reader-bar

A plugin to add a reader bar into your Eleventy template as you scroll the page.
https://thigoap.github.io/11ty-plugin-reader-bar-demo/
5 stars 2 forks source link

Love this plugin - just have a couple of suggestions :) #2

Open snibbo71 opened 3 years ago

snibbo71 commented 3 years ago

I can't quite figure out why you've hardcoded a top of 2px into the style. I seem to be able to override that by putting a top: 0px !important into my style sheets so that's OK I can cope with that.

Lighthouse is complaining about a lack of aria-label on the Up button which I can't seem to get around with altering the code. Could you add that to improve the accessibility aspect of the button?

Other than that, love it - it's really sleek.

thigoap commented 2 years ago

I can't quite figure out why you've hardcoded a top of 2px into the style. I seem to be able to override that by putting a top: 0px !important into my style sheets so that's OK I can cope with that.

Lighthouse is complaining about a lack of aria-label on the Up button which I can't seem to get around with altering the code. Could you add that to improve the accessibility aspect of the button?

Other than that, love it - it's really sleek.

Oh my god! More than one year later, here I am (Python really got me). First of all, thank you for using the plugin and for the compliment.

Also thanks for the suggestions. I implemented them and upated the package in npm. If you still use the plugin I will wait for your feedback before closing the issue.