search

thii / FontAwesome.swift

Use FontAwesome in your Swift projects
MIT License
1.57k stars 266 forks source link

add duotone style #250

Closed MoElnaggar14 closed 4 years ago

MoElnaggar14 commented 4 years ago

add duotone style #223, #230 , all you need is just drag and drop font-awesome pro

ghowen commented 4 years ago

Duotone fontName needs to be FontAwesome5Duotone-Solid, otherwise loading the font will crash the app.

MoElnaggar14 commented 4 years ago

it's related to font files in FontAwesome but it's okay

MatrixSenpai commented 4 years ago

This adds the capability to use a duotone font, but does nothing about actually implementing. If you were to actually put this in a label, image, or other FontAwesomeUIControl subclass, it wouldn't produce the desired result. More needs to be added to the actual UIControl subclasses

MatrixSenpai commented 4 years ago

I'm closing this without merging for now. I want to come back and review this issue later. This solution is incomplete, and I want to implement parts of it, just not now