search

thii / FontAwesome.swift

Use FontAwesome in your Swift projects
MIT License
1.57k stars 266 forks source link

Support coming for FontAwesome v5.13.1 #259

Closed MatrixSenpai closed 3 years ago

MatrixSenpai commented 4 years ago

Just letting everyone know, as of this moment I'm having some issues updating master because of a cli-swift issue.

Support is coming for the latest FontAwesome icons, as soon as I get this figured out. Thank you all for your patience

perlguy99 commented 4 years ago

In case it helps, the script works with tools that are a bit older, I have Xcode 11.5 (11E608c) installed and it runs for me. However, I'm trying to generate all of the Pro fonts and it seems to be missing the duotones and light fonts completely. I turned on "Use Pro Fonts", do you have any other tips for generating ALL of the Pro fonts? Thank you!

perlguy99 commented 4 years ago

FYI, I got much further with the swift CLI script running by renaming /Library/Developer/CommandLineTools and then performing a sudo xcode-select --install. Now the script compiles and tries to run, but I get a segmentation fault that I am trying to debug.

MatrixSenpai commented 4 years ago

Ensure that you've installed the submodule. There's a lot of force-unwrapping optionals in there, especially when it comes to decoding and reading the metadata file.

To install with pro fonts, you'll need to replace the FortAwesome/FontAwesome submodule with the FortAwesome/FontAwesome-Pro submodule, and change the path inside the script

perlguy99 commented 4 years ago

I got the cli-swift file to run properly on one of the developer preview Macs!

perlguy99 commented 4 years ago

Is duotone supported? It looks like I only see 1 of the colors.

MatrixSenpai commented 4 years ago

duotone is not currently supported. I am debating how to show them, and whether to allow them in UILabels. Ligatures and SVGs are the two paths that seem readily available, but i'm not sure if either is the right choice. For now, I am closing all PRs related to them

perlguy99 commented 4 years ago

I created a SwiftUI "demo" app for viewing the FontAwesome images... FontAwesome.SwiftUI.demo

Kedar-27 commented 3 years ago

any ETA?

MatrixSenpai commented 3 years ago

Still working on a few things with the next version. Updated font support will be bundled in. If you need it in the meantime, you can manually add the library and update the font. You can still add it into your pod file, just ensure that it is pointed towards the local path and not the git repository. See more here

hactar commented 3 years ago

5.15.1 is the current version, hope that when you do find the time to upgrade, you can upgrade to the newest version :)

MatrixSenpai commented 3 years ago

Updating right now. Had to fix some shit with swift giving me the runaround. small changes to how things are done under the hood, but no changes to any of the core library or the release process

MatrixSenpai commented 3 years ago

07883a32d49dfc7bdedbeea115067b53dfbeeb43 pushed to master and CP, closing

MatrixSenpai commented 3 years ago

As a note, @thii I was having issues specifically with the ./codegen.swift command. I was getting "This copy of libswiftCore.dylib requires an OS version prior to 10.14.4." I couldn't figure out what was causing it, and since I'm loathe to roll back to a previous version of Xcode, I just went ahead and added an executable target in the Package.swift and changed ./codegen.swift -> swift run tools. codegen.swift got changed to ROOT/tools/main.swift

thii commented 3 years ago

Looks like a prolem with your machine's installed Swift runtime.

MatrixSenpai commented 3 years ago

It might very well be. I don't have a lot of space so I also only have one version of Xcode/swift installed atm. I'm working on getting CI to take care of bumps for us