search

thijse / Arduino-CmdMessenger

CmdMessenger Communication library for Arduino & .NET
Other
208 stars 87 forks source link

Fixed subtle threading issue in ReceivedCommandSignal #7

Closed SartorialOffense closed 8 years ago

SartorialOffense commented 8 years ago

Fixed subtle threading issue where ReceivedCommandSignal was setup to wait for a reply AFTER the reply had already been received from the transport layer. This would result in the response being stomped on when _receivedCommand was set to null. Now WaitForCmd is configured beforehand by the PrepareForWait command and then called. Saw this error every ~10K calls when the response from the Arduino was very fast. Has only been tested on a Arduino Mega 2560 R3.

valkuc commented 8 years ago

Verified. Thank you.

SartorialOffense commented 8 years ago

you are very welcome, your library has saved me a lot of time.

On Wed, May 25, 2016 at 3:02 PM, Valeriy Kucherenko < notifications@github.com> wrote:

Verified. Thank you.

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/thijse/Arduino-CmdMessenger/pull/7#issuecomment-221689904