thilobillerbeck / nixos-config

Everything that tells my nix-powered hosts what stuff to run
1 stars 0 forks source link

Question: how does your invoiceninja module work? #1

Open Ramblurr opened 3 months ago

Ramblurr commented 3 months ago

Hope you don't mind me opening this issue to ask a question!

I was searching for nixos modules for invoiceninja on Github and came across yours.

Reading the module I'm left wondering.. where does the invoiceninja source code come from?

https://github.com/thilobillerbeck/nixos-config/blob/69e48a42abb3ebba76c72bfb2df3713c1dd08c7b/modules/invoiceninja.nix#L7-L12

That seems to build a php environment, but doesn't load any source code.

Would you mind sharing how it works?

Cheers!

thilobillerbeck commented 3 months ago

Hi, this is unfortunately al leftover of a module I omitted a while ago in favor of a docker container, since I needed something running quickly.. I remember downloading the compiled version from the invoiceninja website and just putting it into the path (see options).

I hope I can someday move back to a nixos module. :)

Ramblurr commented 3 months ago

Ah ok, that makes sense! Thanks for the reply.

If you're interested I'm working on an invoiceninja module to upstream to nixpkgs: https://github.com/Ramblurr/nixpkgs/commit/8748e91b2b06e6aa18124098496bee510bf3a40c

I'll probably PR it tomorrow.

thilobillerbeck commented 3 months ago

Great to hear! Thanks for your work 🎉