search

thilojaeggi / WinGetty

An open source REST Backend for creating a private WinGet Repo without having to rely on cloud dependencies.
https://wingetty.dev
GNU Affero General Public License v3.0
191 stars 18 forks source link

Incorporate everything into Docker Compose file #6

Closed amcco1 closed 1 year ago

amcco1 commented 1 year ago

Hey thilo, this looks like a great tool, thanks for making it!

I have one request for simplifying the installation. Could you incorporate everything needed into a single docker-compose file?

I love to use Portainer and I hate when I have to clone a git repo and then run it with docker.

Would you be willing to incorporate everthing needed into the docker image, then could just add a mysql container into the compose file.

Could literally just copy and paste the docker compose file and edit the variables then and be up in running within minutes, without having to clone the repo.

thilojaeggi commented 1 year ago

You don't have to clone the repo, the docker-compose file references the latest stable image. https://github.com/thilojaeggi/WinGetty/blob/main/docker-compose.yml

amcco1 commented 1 year ago

Thanks! I was able to get it up and running with a few small modifications to the compose file. However I have run into a real issue.

When I try to add a package with a name longer than 20 characters it has an error that says [object Object]

Screenshot 2023-07-27 112412

If the package identifier is 20 characters or shorter, it works like a charm. But if its 21+ characters it gives the object object error.

thilojaeggi commented 1 year ago

I see you're running version 0.0.3 which is still in development, if you use the tag "stable" version 0.0.2 gets pulled which should work. You'll have to recreate the database though, since there are some changes between 0.0.2 and 0.0.3

amcco1 commented 1 year ago

I am using the stable tag in my compose file.

Screenshot 2023-07-27 131326

thilojaeggi commented 1 year ago

That's really weird since your screenshot has v0.0.3 in the footer and previous versions don't even have a footer. Could you try pinning it to version 0.0.2 with this image?: ghcr.io/thilojaeggi/wingetty:0.0.2 You'd have to delete the database and packages volumes I'm afraid.

amcco1 commented 1 year ago

Yes that worked, and v0.0.2 does not have the issue with id character length.

Strange that the latest tag is not pulling the correct version.

thilojaeggi commented 1 year ago

The current limitation of the identifier is 20 chars, will be upped in v0.0.3

ImNtReal commented 1 year ago

@amcco1, some projects use the latest tag to track development. I appreciate it when projects that do this include a stable tag, as well.

thilojaeggi commented 1 year ago

@ImNtReal there is a stable tag though, I don't know how amcco1 somehow got a development version instead of 0.0.2 when pulling the following: https://github.com/thilojaeggi/WinGetty/pkgs/container/wingetty/106822412?tag=stable

ImNtReal commented 1 year ago

@thilojaeggi I didn't mean to imply that there wasn't. I just didn't know if OP had looked for one. :)

thilojaeggi commented 1 year ago

Ah, completely misunderstood that then. When looking at OP's screenshot they were using the stable tag though, although maybe they went from latest to stable without removing the "latest (dev)" image.