General improvements - Githubissues

thimc / lfimg

Image preview support for lf (list files) using Überzug

GNU General Public License v3.0

252 stars 45 forks source link

General improvements #17

Closed XPhyro closed 3 years ago

XPhyro commented 3 years ago

The following changes are included in this pull request:

Added .ino support
Added .xls and .xlsx support
Refactored bat check
Fixed invalid odt case
Updated README.md
Added .mka support
Removed redundant code

thimc commented 3 years ago

Merged although I have to admit that I am not a fan of the following statement below.

I would prefer if we could change this: *.ino) batorcat --language=cpp "$1"

to this, but bat does not seem to offer such a feature that I am aware of which makes the preview script more cluttered than it needs to be in my opinion. *) batorcat --language=auto "$1"

XPhyro commented 3 years ago

I agree. Though it looks like bat determines the language based on the file extension, and it does not know that an Arduino file is just C or C++. I'll see if I can find a workaround.