search

thimc / lfimg

Image preview support for lf (list files) using Überzug
GNU General Public License v3.0
252 stars 45 forks source link

Doesnt clean previewed pictures #52

Closed og900aero closed 11 months ago

og900aero commented 11 months ago

I'm on Debian 12 with ueberzug and lf. I have 2 problem:

  1. If I move from image to image, it updates the preview image fine, but if I move from image to text file or directory, it no longer deletes the image, but the preview image of the text file/directory appears behind it
  2. There are some images that are displayed upside down in the preview image, even though when I open the image, it displays fine. I found that this happens with images where the function below returns a value other than 1: identify -format '%[EXIF:Orientation]\n' -- "$file"
thimc commented 11 months ago

Hi,

I'm on Debian 12 with ueberzug and lf. I have 2 problem:

  1. If I move from image to image, it updates the preview image fine, but if I move from image to text file or directory, it no longer deletes the image, but the preview image of the text file/directory appears behind it

Which version of lf are you running? I have a vague memory of this being the default behaviour before (whichever version of lf it was) and upstream changed the API so that the clean hook would be executed on directories as well.

  1. There are some images that are displayed upside down in the preview image, even though when I open the image, it displays fine. I found that this happens with images where the function below returns a value other than 1: identify -format '%[EXIF:Orientation]\n' -- "$file"

I can't say I've seen this behaviour before, I don't know which version of ueberzug you are using or which version Debian packages. We do not modify the image orientation so I find this hard to believe to be a problem for lfimg

og900aero commented 11 months ago

Hi,

I'm on Debian 12 with ueberzug and lf. I have 2 problem:

  1. If I move from image to image, it updates the preview image fine, but if I move from image to text file or directory, it no longer deletes the image, but the preview image of the text file/directory appears behind it

Which version of lf are you running? I have a vague memory of this being the default behaviour before (whichever version of lf it was) and upstream changed the API so that the clean hook would be executed on directories as well.

  1. There are some images that are displayed upside down in the preview image, even though when I open the image, it displays fine. I found that this happens with images where the function below returns a value other than 1: identify -format '%[EXIF:Orientation]\n' -- "$file"

I can't say I've seen this behaviour before, I don't know which version of ueberzug you are using or which version Debian packages. We do not modify the image orientation so I find this hard to believe to be a problem for lfimg

I try the new source and the stable r30 version too. The ueberzug's version is 18.1.9 (Debian 12 stable repo). It's interesting that the lf site has a solution for previewing images, and it works well, but it's much slower than your solution: https://github.com/gokcehan/lf/wiki/Previews#image-previews