code cleanup - Githubissues

thimc / vifmimg

Image previews for Vifm (vi file manager) using Überzug

GNU General Public License v3.0

242 stars 26 forks source link

code cleanup #24

Closed narukeh closed 3 years ago

narukeh commented 3 years ago

There is no need for if cause there is && exit
vifmrun is posix, so use /bin/sh for faster speed 🤷why not🤷
also minor fix in vifmimg when echoing error choice.

(Checkout shellcheck it helps you a lot.)

(Also i think that in vifmrun, the last command should be cleanup, but this PR is just to write the same code cleaner/faster.)