search

thin-edge / tedge-container-plugin

thin-edge.io community plugin to manage containers and container groups (aka docker compose)
MIT License
6 stars 2 forks source link

fix(packaging): remove executable permission bits from systemd service definition #50

Closed reubenmiller closed 5 days ago

reubenmiller commented 5 days ago

Systemd service definitions should not be marked as executable as unit files are only configuration.

Otherwise systemd shows a warning when installing the service:

Synchronizing state of tedge-container-monitor.service with SysV service script with /lib/systemd/systemd-sysv-install.
Executing: /lib/systemd/systemd-sysv-install enable tedge-container-monitor
Configuration file /lib/systemd/system/tedge-container-monitor.service is marked executable. Please remove executable permission bits. Proceeding anyway.
github-actions[bot] commented 5 days ago

Robot Results

:white_check_mark: Passed :x: Failed :next_track_button: Skipped Total Pass % :stopwatch: Duration
7 0 1 7 100 1m21.735s

Passed Tests

Name :stopwatch: Duration Suite
Get Configuration 5.195 s Operations
Install container-group package 16.346 s Operations
Install container-group with multiple files 27.314 s Operations
Uninstall container-group 2.841 s Operations
Install container package 16.333 s Operations
Uninstall container package 6.030 s Operations
Service status 7.675 s Telemetry-Main