Closed Bravo555 closed 5 months ago
Attention: Patch coverage is 0%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 76.6%. Comparing base (
e7bf843
) to head (c0b0f6a
). Report is 1 commits behind head on main.
:white_check_mark: Passed | :x: Failed | :next_track_button: Skipped | Total | Pass % | :stopwatch: Duration |
---|---|---|---|---|---|
429 | 0 | 3 | 429 | 100 | 0s |
Proposed changes
Instead of retrying MQTT connection immediately for some errors, apply delay before retrying connection by default for all errors.
One could argue that for errors where we know we're going to receive it again, e.g. misconfiguring certificates, we should exit instead of retrying, but because rumqttc doesn't organize its errors very well, it would be hard to ensure that every variant is covered, whereas this is simple and works.
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments