Use Command<Payload> for log, config and firmware commands

didier-wenzek commented 2 months ago

Proposed changes

Use the Command<Payload> representation for log, config and firmware commands

This is required for:

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[x] I ran cargo fmt as mentioned in CODING_GUIDELINES
[x] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 43.39623% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 76.2%. Comparing base (25ca6e6) to head (03e8699). Report is 1 commits behind head on main.

Additional details and impacted files

| [Files](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2846?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge) | Coverage Δ | | |---|---|---| | [...s/core/tedge\_agent/src/operation\_file\_cache/mod.rs](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2846?src=pr&el=tree&filepath=crates%2Fcore%2Ftedge_agent%2Fsrc%2Foperation_file_cache%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge#diff-Y3JhdGVzL2NvcmUvdGVkZ2VfYWdlbnQvc3JjL29wZXJhdGlvbl9maWxlX2NhY2hlL21vZC5ycw==) | `0.0% <ø> (ø)` | | | [...rates/extensions/tedge\_config\_manager/src/actor.rs](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2846?src=pr&el=tree&filepath=crates%2Fextensions%2Ftedge_config_manager%2Fsrc%2Factor.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge#diff-Y3JhdGVzL2V4dGVuc2lvbnMvdGVkZ2VfY29uZmlnX21hbmFnZXIvc3JjL2FjdG9yLnJz) | `64.8% <ø> (ø)` | | | [crates/extensions/tedge\_log\_manager/src/actor.rs](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2846?src=pr&el=tree&filepath=crates%2Fextensions%2Ftedge_log_manager%2Fsrc%2Factor.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge#diff-Y3JhdGVzL2V4dGVuc2lvbnMvdGVkZ2VfbG9nX21hbmFnZXIvc3JjL2FjdG9yLnJz) | `66.8% <ø> (ø)` | | | [crates/core/tedge\_api/src/commands.rs](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2846?src=pr&el=tree&filepath=crates%2Fcore%2Ftedge_api%2Fsrc%2Fcommands.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge#diff-Y3JhdGVzL2NvcmUvdGVkZ2VfYXBpL3NyYy9jb21tYW5kcy5ycw==) | `83.5% <43.3%> (-3.4%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2846/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge)

github-actions[bot] commented 2 months ago

Robot Results

:white_check_mark: Passed	:x: Failed	:next_track_button: Skipped	Total	Pass %	:stopwatch: Duration
432	0	3	432	100	0s

thin-edge / thin-edge.io