Closed Ruadhri17 closed 1 month ago
Attention: Patch coverage is 27.65957%
with 34 lines
in your changes are missing coverage. Please review.
Project coverage is 78.1%. Comparing base (
33e6890
) to head (eb60c35
). Report is 51 commits behind head on main.:exclamation: Current head eb60c35 differs from pull request most recent head 40e1cfe
Please upload reports for the commit 40e1cfe to get more accurate results.
:white_check_mark: Passed | :x: Failed | :next_track_button: Skipped | Total | Pass % | :stopwatch: Duration |
---|---|---|---|---|---|
435 | 0 | 3 | 435 | 100 | 0s |
After discussion with @reubenmiller, we concluded that:
Hence:
tedge-apt-plugin
:-(tedge config
setting have to be added: software.plugin.include
and software.plugin.exclude
software.plugin.include
regex or doesn't match the software.plugin.exclude
. The logic is that the primary usage will be to exclude packages (say all libs and kernel modules) and only then add some exceptions (say to include the libc
).software.plugin.include
is provided, keep a package if its name matchessoftware.plugin.exclude
is provided, keep a package if its name doesn't matchsoftware.plugin.max_packages
packages.
Proposed changes
This PR introduce two new tedge configs:
software.plugin.include
andsoftware.plugin.exclude
. This allows to filter packages list output insm-plugin
using include pattern and exclude pattern. When both patterns are provided in config, include pattern takes precedence over exclude pattern.Types of changes
Paste Link to the issue
2848
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments