Closed albinsuresh closed 1 month ago
Attention: Patch coverage is 94.28571%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 78.0%. Comparing base (
8a91efb
) to head (d52bbdf
). Report is 2 commits behind head on main.
:white_check_mark: Passed | :x: Failed | :next_track_button: Skipped | Total | Pass % | :stopwatch: Duration |
---|---|---|---|---|---|
443 | 0 | 3 | 443 | 100 | 1h0m32.488258999s |
However, the code related to health status is still fragile because unstructured.
- There are two similar
HealthStatus
structs defined by c8y related crates (c8y_api
andc8y_mapper_ext
).- The respective roles of
tedge_api
andc8y_api
is not clear. Several methods should be moved intotedge_api
to encapsulate all the tedge conventions.- This PR introduces
UP_STATUS
andDOWN_STATUS
constants, but"up"
and"down"
literals are used everywhere.
I completely agree and this was the cleanup that I wanted to do as well. But, kept the minimal changes in this PR because of the urgency in fixing the bug. Will definitely do a follow-up PR with all that cleanup.
Proposed changes
up
Types of changes
Paste Link to the issue
https://github.com/thin-edge/thin-edge.io/issues/2902
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments