feat(sm-plugin): skip package download if the url is empty

Ruadhri17 commented 4 months ago

Proposed changes

This PR adds an extra check in software_update to skip the download process if the payload contains an empty url. A system test was added to prove that the error no longer exists when an empty url is provided in the local command.

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

2857

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[x] I ran cargo fmt as mentioned in CODING_GUIDELINES
[x] I used cargo clippy as mentioned in CODING_GUIDELINES
[x] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.1%. Comparing base (8a91efb) to head (05a644e). Report is 6 commits behind head on main.

Additional details and impacted files

| [Files](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2905?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge) | Coverage Δ | | |---|---|---| | [crates/common/download/src/download.rs](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2905?src=pr&el=tree&filepath=crates%2Fcommon%2Fdownload%2Fsrc%2Fdownload.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge#diff-Y3JhdGVzL2NvbW1vbi9kb3dubG9hZC9zcmMvZG93bmxvYWQucnM=) | `80.8% <100.0%> (+<0.1%)` | :arrow_up: | | [crates/core/tedge\_api/src/commands.rs](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2905?src=pr&el=tree&filepath=crates%2Fcore%2Ftedge_api%2Fsrc%2Fcommands.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge#diff-Y3JhdGVzL2NvcmUvdGVkZ2VfYXBpL3NyYy9jb21tYW5kcy5ycw==) | `92.9% <100.0%> (ø)` | | | [crates/core/tedge\_api/src/software.rs](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2905?src=pr&el=tree&filepath=crates%2Fcore%2Ftedge_api%2Fsrc%2Fsoftware.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge#diff-Y3JhdGVzL2NvcmUvdGVkZ2VfYXBpL3NyYy9zb2Z0d2FyZS5ycw==) | `93.1% <66.6%> (+29.4%)` | :arrow_up: | ... and [9 files with indirect coverage changes](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2905/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge)

github-actions[bot] commented 4 months ago

Robot Results

:white_check_mark: Passed	:x: Failed	:next_track_button: Skipped	Total	Pass %	:stopwatch: Duration
442	0	3	442	100	1h1m19.518955999s

thin-edge / thin-edge.io