ci: add explicit dependency on build job

reubenmiller commented 1 month ago

Proposed changes

Note: still needs to be tested by running through the merge queue

Prevent progression of the workflow if a build job is cancelled or skipped.

Without a direct link to the publish and build jobs, the publish was previously triggered if the test job was marked as skipped (due to its upstream job being not marked as "success").

Types of changes

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

https://github.com/thin-edge/thin-edge.io/issues/2908

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[ ] I ran cargo fmt as mentioned in CODING_GUIDELINES
[ ] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.1%. Comparing base (05a644e) to head (613e8dd). Report is 5 commits behind head on main.

Additional details and impacted files

[see 5 files with indirect coverage changes](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2909/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge)

github-actions[bot] commented 1 month ago

Robot Results

:white_check_mark: Passed	:x: Failed	:next_track_button: Skipped	Total	Pass %	:stopwatch: Duration
444	0	3	444	100	1h0m46.519414s

thin-edge / thin-edge.io