refactoring: rename workflow related structs

didier-wenzek commented 1 month ago

Proposed changes

The former names were no more accurate as this actor responsibilities have been extended to include workflow coordination.

struct TedgeOperationConverterActor renamed WorkflowActor
mod tedge_operation_converter renamed operation_workflows
workflow related code moved into mod operation_workflows

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[x] I ran cargo fmt as mentioned in CODING_GUIDELINES
[x] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 10.00000% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 77.8%. Comparing base (a507d7a) to head (2e6dd4e). Report is 1 commits behind head on main.

:exclamation: Current head 2e6dd4e differs from pull request most recent head afd5de3

Please upload reports for the commit afd5de3 to get more accurate results.

Additional details and impacted files

| [Files](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2912?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge) | Coverage Δ | | |---|---|---| | [crates/core/tedge\_agent/src/agent.rs](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2912?src=pr&el=tree&filepath=crates%2Fcore%2Ftedge_agent%2Fsrc%2Fagent.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge#diff-Y3JhdGVzL2NvcmUvdGVkZ2VfYWdlbnQvc3JjL2FnZW50LnJz) | `0.0% <ø> (ø)` | | | [crates/core/tedge\_agent/src/lib.rs](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2912?src=pr&el=tree&filepath=crates%2Fcore%2Ftedge_agent%2Fsrc%2Flib.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge#diff-Y3JhdGVzL2NvcmUvdGVkZ2VfYWdlbnQvc3JjL2xpYi5ycw==) | `0.0% <ø> (ø)` | | | [...core/tedge\_agent/src/operation\_workflows/config.rs](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2912?src=pr&el=tree&filepath=crates%2Fcore%2Ftedge_agent%2Fsrc%2Foperation_workflows%2Fconfig.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge#diff-Y3JhdGVzL2NvcmUvdGVkZ2VfYWdlbnQvc3JjL29wZXJhdGlvbl93b3JrZmxvd3MvY29uZmlnLnJz) | `0.0% <ø> (ø)` | | | [...tedge\_agent/src/operation\_workflows/message\_box.rs](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2912?src=pr&el=tree&filepath=crates%2Fcore%2Ftedge_agent%2Fsrc%2Foperation_workflows%2Fmessage_box.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge#diff-Y3JhdGVzL2NvcmUvdGVkZ2VfYWdlbnQvc3JjL29wZXJhdGlvbl93b3JrZmxvd3MvbWVzc2FnZV9ib3gucnM=) | `76.1% <ø> (ø)` | | | [.../core/tedge\_agent/src/operation\_workflows/tests.rs](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2912?src=pr&el=tree&filepath=crates%2Fcore%2Ftedge_agent%2Fsrc%2Foperation_workflows%2Ftests.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge#diff-Y3JhdGVzL2NvcmUvdGVkZ2VfYWdlbnQvc3JjL29wZXJhdGlvbl93b3JrZmxvd3MvdGVzdHMucnM=) | `94.4% <100.0%> (ø)` | | | [.../core/tedge\_agent/src/operation\_workflows/actor.rs](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2912?src=pr&el=tree&filepath=crates%2Fcore%2Ftedge_agent%2Fsrc%2Foperation_workflows%2Factor.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge#diff-Y3JhdGVzL2NvcmUvdGVkZ2VfYWdlbnQvc3JjL29wZXJhdGlvbl93b3JrZmxvd3MvYWN0b3IucnM=) | `50.3% <0.0%> (ø)` | | | [...ore/tedge\_agent/src/operation\_workflows/builder.rs](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2912?src=pr&el=tree&filepath=crates%2Fcore%2Ftedge_agent%2Fsrc%2Foperation_workflows%2Fbuilder.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge#diff-Y3JhdGVzL2NvcmUvdGVkZ2VfYWdlbnQvc3JjL29wZXJhdGlvbl93b3JrZmxvd3MvYnVpbGRlci5ycw==) | `90.2% <66.6%> (ø)` | | | [...es/core/tedge\_agent/src/operation\_workflows/mod.rs](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2912?src=pr&el=tree&filepath=crates%2Fcore%2Ftedge_agent%2Fsrc%2Foperation_workflows%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge#diff-Y3JhdGVzL2NvcmUvdGVkZ2VfYWdlbnQvc3JjL29wZXJhdGlvbl93b3JrZmxvd3MvbW9kLnJz) | `0.0% <0.0%> (ø)` | | ... and [14 files with indirect coverage changes](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2912/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge)

github-actions[bot] commented 1 month ago

Robot Results

:white_check_mark: Passed	:x: Failed	:next_track_button: Skipped	Total	Pass %	:stopwatch: Duration
452	0	3	452	100	1h5m21.981268999s

thin-edge / thin-edge.io