Cleanup unused code and fix doc related to SmartREST 104

rina23q commented 4 weeks ago

Proposed changes

I found 104 message is unused by us. Fix the doc and remove the unused code.

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[x] I ran cargo fmt as mentioned in CODING_GUIDELINES
[x] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.9%. Comparing base (15b7e26) to head (7d57cad). Report is 20 commits behind head on main.

Additional details and impacted files

| [Files](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2913?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge) | Coverage Δ | | |---|---|---| | [crates/core/c8y\_api/src/smartrest/inventory.rs](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2913?src=pr&el=tree&filepath=crates%2Fcore%2Fc8y_api%2Fsrc%2Fsmartrest%2Finventory.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge#diff-Y3JhdGVzL2NvcmUvYzh5X2FwaS9zcmMvc21hcnRyZXN0L2ludmVudG9yeS5ycw==) | `66.6% <ø> (+9.8%)` | :arrow_up: | | [...s/extensions/c8y\_mapper\_ext/src/service\_monitor.rs](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2913?src=pr&el=tree&filepath=crates%2Fextensions%2Fc8y_mapper_ext%2Fsrc%2Fservice_monitor.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge#diff-Y3JhdGVzL2V4dGVuc2lvbnMvYzh5X21hcHBlcl9leHQvc3JjL3NlcnZpY2VfbW9uaXRvci5ycw==) | `97.7% <100.0%> (+0.1%)` | :arrow_up: | ... and [23 files with indirect coverage changes](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2913/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge)

github-actions[bot] commented 4 weeks ago

Robot Results

:white_check_mark: Passed	:x: Failed	:next_track_button: Skipped	Total	Pass %	:stopwatch: Duration
451	0	3	451	100	1h2m25.494147s

thin-edge / thin-edge.io