chore: bump MSRV in the workflow to 1.78

thin-edge / thin-edge.io

The open edge framework for lightweight IoT devices

https://thin-edge.io

Apache License 2.0

219 stars 54 forks source link

chore: bump MSRV in the workflow to 1.78 #2965

Closed Ruadhri17 closed 3 months ago

Ruadhri17 commented 3 months ago

Proposed changes

This PR bumps MSRV in the workflow. Version 1.78 introduced diagnostic_attribute that will be used in #2943.

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
[ ] Documentation Update (if none of the other choices apply)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

[x] I have read the CONTRIBUTING doc
[x] I have signed the CLA (in all commits with git commit -s)
[x] I ran cargo fmt as mentioned in CODING_GUIDELINES
[x] I used cargo clippy as mentioned in CODING_GUIDELINES
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.2%. Comparing base (23c2714) to head (7802710). Report is 29 commits behind head on main.

Additional details and impacted files

[see 14 files with indirect coverage changes](https://app.codecov.io/gh/thin-edge/thin-edge.io/pull/2965/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thin-edge)

reubenmiller commented 3 months ago

@Ruadhri17 I pushed a commit to fix some of the build matrix setup which was required since we can now use the default MSRV for all targets.

Though since we're using the merge queue the workflow won't use the new value in the build-workflow.yaml file, so it might make sense to do the build-workflow.yaml changes in one commit, then change the MSRV in a follow up PR.

This would work because the following details which workflows versions are used when:

On PR checks, the workflows from the main branch are used
On merge queue checks, the workflows in the PR branch are used

Bravo555 commented 3 months ago

Can we bump to 1.79 instead? It has improvements for extending lifetimes, and I could really use that in my PR, without which I have to either do additional string clones or writing more complicated code using Cow.

EDIT: I see 1.79 is not yet available in meta-rust, so it will probably have to wait a little bit.

github-actions[bot] commented 3 months ago

Robot Results

:white_check_mark: Passed	:x: Failed	:next_track_button: Skipped	Total	Pass %	:stopwatch: Duration
453	0	3	453	100	57m8.963288999s

reubenmiller commented 3 months ago

meta-rust

Good catch about the meta-rust dependency. Good thing that 1.78 is supported by it.