thindil / steamsky

Mirror of a roguelike in sky with a steampunk setting
https://www.laeran.pl.eu.org/repositories/steamsky
94 stars 7 forks source link

Pressing and Holding Movement Keys Causes Unanimated Movement #90

Closed ghost closed 2 years ago

ghost commented 3 years ago

Describe the bug I noticed whilst moving that if I continually press any movement key, the ship appears to lag and spontaneously appear multiple tiles away, rather than moving normally. This creates difficulty while moving quickly, as you cannot predict where your ship will appear.

Technical Info:

thindil commented 3 years ago

Hello and thank you for the report again.

Personally, I'm using the mouse for that kind of movement, that's why it is moving in that way. 😄 And I also need some help. How it should work? I'm thinking about adding some pause between each movement during holding the key. Just this can be a bit complicated and will not arrive too soon in the development version of the game.

ghost commented 3 years ago

Hello and thank you for the report again.

Personally, I'm using the mouse for that kind of movement, that's why it is moving in that way. 😄 And I also need some help. How it should work? I'm thinking about adding some pause between each movement during holding the key. Just this can be a bit complicated and will not arrive too soon in the development version of the game.

I mean, sure, if you point and click, instant travel is fine. However, while held. it should be more similar to this:

https://user-images.githubusercontent.com/40145743/136925180-3c64a94a-6260-41ce-a0d0-963f1d857bbe.mp4

Instead, I'm receiving these movements:

https://user-images.githubusercontent.com/40145743/136926730-297eeefe-2779-4142-bf5c-dbfb78ecc4b6.mp4

thindil commented 3 years ago

That's looks like the problem with the Tk library on Windows, or something not related exactly to the movement, but drawing. 😞 On Linux, the movement is smooth, no lags. I'm not sure if I can fix it or not. I will investigate, but please don't expect too much.

thindil commented 2 years ago

Better late than never. 😄 I did some tests with the newest stable version (7.0.5) and it looks like it is fixed. If this is not a problem, can someone check it too? Thanks in advance. 😄

thindil commented 2 years ago

Looks to me as fixed, I close it. If someone has the same problem, please reopen it or create a new issue. Thank you for reporting. :smile: