thingco / shared-frontend-libs

0 stars 0 forks source link

[FEAT] - naming convention for change PIN flow #76

Closed DanCouper closed 2 years ago

DanCouper commented 3 years ago

Which package is this related to?

Specify the package, or if it is a new package suggest a name.

If this covers multiple packages, if possible open an issue for both and PR separately: this will keep the PR's scope as small as possible (plus each package needs separate version bumps & republishing after the fix has been applied).

Is your feature request related to a problem? Please describe. When a user wants to change their PIN, they first validate the current PIN, then enter a new one.

The naming convention for these states should be obviously linked, as they must exist as a pair. This was originally a change request on the PIN stage PR (#73 ), but moving this to an issue to be fixed later. From the PR:

I think it needs to be named as a pair here so it's obvious they work together -- I just can't think of a good convention. To be verbose needs to be:

ChangingPinValidatingCurrentPin ChangingPinSubmittingNewPin

But that's pretty awful