search

thingdom / node-neo4j

[RETIRED] Neo4j graph database driver (REST API client) for Node.js
Apache License 2.0
925 stars 135 forks source link

RC2 comes before alpha5 in terms of semver #191

Open dozoisch opened 8 years ago

dozoisch commented 8 years ago

Semver compares prelease version in ASCII. Turns out RC is smaller than alpha. With http://semver.npmjs.com/ you can see that writing a range like ~2.0.0-RC2 selects RC2 and alpha 1 to 5.

Just changing the label to rc in lowercase would fix it.

http://semver.org/#spec-item-11

When major, minor, and patch are equal, a pre-release version has lower precedence than a normal version. Example: 1.0.0-alpha < 1.0.0. Precedence for two pre-release versions with the same major, minor, and patch version MUST be determined by comparing each dot separated identifier from left to right until a difference is found as follows: identifiers consisting of only digits are compared numerically and identifiers with letters or hyphens are compared lexically in ASCII sort order.

aseemk commented 8 years ago

Nice catch!

I'm a bit stretched thin right now, but at the top of my list with this project is to simply finish the docs and merge the v2 branch, making it official. So no more RC/rc etc. at that point anyway.

If I don't get to that soon, I'll update RC to rc. =) Thanks again!

dozoisch commented 8 years ago

awesome :) thanks a lot for your time!