search

thingnotok / obsidian-toggle-list

This is a simple plugin for Obsidian to overwrite the default behavior of toggle checkbox status. Also, it offers a simple way to toggle through frequently used attributes: task states, task tags, highlighted list, etc.
MIT License
44 stars 7 forks source link

Bug: hotkeys for binded state group commands don't work after renaming the command. #22

Open YousufSSyed opened 1 year ago

YousufSSyed commented 1 year ago

Let's say I have a state group command binding with a certain name, assign a hotkey to the binding with that name. If I change then name, then the hotkey no longer works unless I change it back. I noticed in the hotkeys.json file, you give command names to Obsidian, whatever names I write down in the plugin settings.

What if in your code, you generated IDs for each state group binding, and used those in the command names internally, so that if a binding is renamed, the hotkey still works?

thingnotok commented 1 year ago

Hi, thank you for the suggestion! I will add it in the next update!

YousufSSyed commented 1 year ago

How has that been going?

thingnotok commented 1 year ago

Hi, after reviewing the request, I've realized that implementing this feature would be time-consuming. Currently, commands are all unregistered and then be registered after setting is saved/validation. I'm planning to reorganize the structure of the settings to accommodate your needs and potential new features. I apologize for any inconvenience, and I can't guarantee a quick completion as I've been quite busy with work lately.

YousufSSyed commented 1 year ago

Should I keep this open? Setting the commands is mostly only done when first setring up the plugin, and honestly I haven't touched it at all since I opened this issue. I just thought this is something you should consider.

thingnotok commented 1 year ago

Please keep it. I really appreciate this suggestion. 😀 I've been troubled by this issue before as well. However, as you mentioned, since it rarely occurs, I decided to set it aside for the time being.

technotherion commented 2 weeks ago

What if instead of showing the name of the state group, the placeholder was shown instead? e.g. "binding 0, binding 1, binding 2"

YousufSSyed commented 2 weeks ago

Lol I don't even use this plugin anymore, I switched to Neovim and am much happier, I'm turning off reply notifications now.